fix(amazonq): rely on server-side data to communicate number of code generations remaining #6370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siakmun-aws
changed the title
neilk-aws
suggested changes
Jan 14, 2025
packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
packages/core/src/test/amazonqFeatureDev/session/sessionState.test.ts
Outdated
Show resolved
Hide resolved
packages/amazonq/.changes/next-release/Feature-f03a4f2f-5819-4276-b914-be0b1a4ecedf.json
Outdated
Show resolved
Hide resolved
…ata to communicate number of code generations remaining
siakmun-aws
changed the title
|
…ata to communicate number of code generations remaining
siakmun-aws
changed the title
neilk-aws
approved these changes
Jan 15, 2025
neilk-aws
approved these changes
Jan 15, 2025
Contributor
|
Nice changelog! I'll merge this for tomorrow's testing window. But please followup with a fix for the failing jscpd (copy-paste detection) issue. |
avi-alpert
pushed a commit
to avi-alpert/aws-toolkit-vscode
that referenced
this pull request
Jan 15, 2025
aws#6370 ## Problem Previously remaining code generation iterations are always displayed. ## Solution Only display when it goes down to 2 or less.
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
aws#6370 Previously remaining code generation iterations are always displayed. Only display when it goes down to 2 or less.
kevluu-aws
pushed a commit
to kevluu-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 23, 2025
aws#6370 ## Problem Previously remaining code generation iterations are always displayed. ## Solution Only display when it goes down to 2 or less.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
aws#6370 ## Problem Previously remaining code generation iterations are always displayed. ## Solution Only display when it goes down to 2 or less.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously remaining code generation iterations are always displayed.
Solution
Only display when it goes down to 2 or less.
feature/xbranches will not be squash-merged at release time.